fix: correct inverted equality checks in WarUtils.isRelated() - #625
Open
elharo wants to merge 2 commits into
Open
fix: correct inverted equality checks in WarUtils.isRelated()#625elharo wants to merge 2 commits into
elharo wants to merge 2 commits into
Conversation
The method returned false when version, type, classifier, or scope were equal between artifact and dependency — the opposite of the intended logic. Fixed by negating the equality checks. Fixes apache#619
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes WarUtils.isRelated() so it returns false only when version, type, classifier, or scope differ between an Artifact and a Dependency (instead of when they’re equal), addressing the inverted-equality bug described in #619.
Changes:
- Corrected the inverted equality checks in
WarUtils.isRelated()forversion,type,classifier, andscope. - Added a new JUnit test class covering several
isRelated()scenarios.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/main/java/org/apache/maven/plugins/war/util/WarUtils.java |
Fixes isRelated() comparison logic so matching artifacts/dependencies are treated as related. |
src/test/java/org/apache/maven/plugins/war/util/WarUtilsTest.java |
Adds unit tests for isRelated() behavior across attribute mismatch cases. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #619
WarUtils.isRelated()returnedfalsewhenversion,type,classifier, orscopewere equal between artifact and dependency — the opposite of the intended logic (should returnfalseonly when they differ).Includes TDD: wrote failing tests first (7 test cases covering all
isRelated()branches), then applied the fix.