Skip to content

Add support for automatic module name#522

Closed
dmlloyd wants to merge 1 commit into
apache:maven-jar-plugin-3.xfrom
dmlloyd:autoname-3.x
Closed

Add support for automatic module name#522
dmlloyd wants to merge 1 commit into
apache:maven-jar-plugin-3.xfrom
dmlloyd:autoname-3.x

Conversation

@dmlloyd

@dmlloyd dmlloyd commented Jan 14, 2026

Copy link
Copy Markdown

Fixes #520 for the 3.x branch.

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@elharo elharo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove log messages


if (automaticModuleName != null && !automaticModuleName.isEmpty()) {
if (containsModuleDescriptor) {
getLog().warn("Not setting automatic module name, because a module descriptor was found.");

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this should have log messages. Having a module descriptor should not cause a warning.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand this warning as being not about the presence of a module descriptor, but rather about the present of an automatic module name in a context where it should not be present.

Note: this set of changes is the same as #521, only applied to different branches. Comments here apply also to #521.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having a module descriptor does not cause a warning; having a module descriptor which conflicts with a defined automatic module name should cause a warning.

@slachiewicz slachiewicz marked this pull request as draft June 14, 2026 18:41
@elharo elharo closed this Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants