Add support for automatic module name#522
Closed
dmlloyd wants to merge 1 commit into
Closed
Conversation
elharo
requested changes
Jun 14, 2026
|
|
||
| if (automaticModuleName != null && !automaticModuleName.isEmpty()) { | ||
| if (containsModuleDescriptor) { | ||
| getLog().warn("Not setting automatic module name, because a module descriptor was found."); |
Contributor
There was a problem hiding this comment.
I don't think this should have log messages. Having a module descriptor should not cause a warning.
Contributor
There was a problem hiding this comment.
I understand this warning as being not about the presence of a module descriptor, but rather about the present of an automatic module name in a context where it should not be present.
Note: this set of changes is the same as #521, only applied to different branches. Comments here apply also to #521.
Author
There was a problem hiding this comment.
Having a module descriptor does not cause a warning; having a module descriptor which conflicts with a defined automatic module name should cause a warning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #520 for the 3.x branch.
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
mvn -Prun-its verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.