(docs) Add moditect-maven-plugin as it is a less complex way for Java 8 with java module descriptors#1062
(docs) Add moditect-maven-plugin as it is a less complex way for Java 8 with java module descriptors#1062bmarwell wants to merge 1 commit into
Conversation
… 8 with java module descriptors
|
Actually the section saying that we need to run <sources>
<source>
<directory>src/main/java</directory>
<targetVersion>8</targetVersion>
</source>
<source>
<directory>src/main/java_9</directory>
<targetVersion>9</targetVersion>
</source>
</sources>We could amend the pull request so that instead of being "two compilations versus one compilation", make it "explicit module-info versus module-info derived from the pom.xml". We may need to test the above snippet first for making sure that it works in this context too. |
desruisseaux
left a comment
There was a problem hiding this comment.
I tried the approach described in above comment and it did not worked. It is a bit tricky to compile only a module-info.java file when everything else has been compiled as a class-path project. I just noticed that indeed, the existing text about using maven-compiler-plugin compiles the whole project twice. Therefore, I have no change to propose.
Adds the less complex moditect plugin to the module-info docs which is probably more helpful than compiling sources twice.
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
mvn -Prun-its verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.