refactor(windows): reuse packaged verifier for rollback - #3707
Open
testikun wants to merge 1 commit into
Open
Conversation
Refs apache#3575 Generated-by: Codex
testikun
force-pushed
the
codex/issue-3575-verifier-reuse
branch
from
August 24, 2026 12:15
053ad7d to
18a5aba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the rollback verifier's private
assertLaunchableCDP wrapper with the existingverifyPackagedWindowsAppauthority, using the explicitlegacy-baselinecontract for restored pre-upgrade installations.The rollback-specific filesystem, registry, backup, recovery, fail-closed, and
.onInstFailedassertions are unchanged. The duplicate process/renderer/version plumbing is removed, and a focused harness test pins the delegation contract.Fixes #3575
Verification
node --test scripts/verify-windows-harness.test.mjs— 40 passednpm --workspace @maka/eval run build— passed (required release-test fixture)node --test scripts/product-release.test.mjs scripts/verify-windows-harness.test.mjs— 66 passednpm run lint— passednpx biome check scripts/verify-windows-installer-rollback.mjs scripts/verify-windows-harness.test.mjs— passednode --checkfor both changed scripts andgit diff --check— passednpm run typecheckcurrently reports unrelated errors in unmodified Runtime Host, CLI, UI, and Desktop files on the latestmain.中文摘要
本 PR 复用已有的 packaged-app verifier 来验证回滚后的旧版本安装,固定使用
legacy-baseline契约,删除重复的 CDP/进程/版本检查代码;所有备份、注册表、失败恢复和.onInstFailed回滚行为保持不变,并补充了 delegation 回归测试。AI use
Tool: OpenAI Codex assisted with issue analysis, implementation, tests, and verification.