Skip to content

fix(desktop): prevent proxy password mask corruption - #3704

Draft
Sun-GLiang wants to merge 2 commits into
apache:mainfrom
Sun-GLiang:fix/3696-proxy-password-editing
Draft

fix(desktop): prevent proxy password mask corruption#3704
Sun-GLiang wants to merge 2 commits into
apache:mainfrom
Sun-GLiang:fix/3696-proxy-password-editing

Conversation

@Sun-GLiang

Copy link
Copy Markdown
Contributor

Summary

  • keep saved proxy credentials out of persisted settings and Renderer input values
  • add an explicit keep/replace/delete credential contract with a shared Runtime Host operation lane
  • keep password editing local until blur or Enter, make Eye reveal the current draft, and remove Copy only from the proxy password field
  • preserve schema-v1 config import/export compatibility with preflight validation

Fixes #3696

Dependency

Verification

  • npm test — all workspace tests passed; Desktop 1393/1393
  • focused proxy password tests — 36/36
  • offline authenticated proxy E2E — 1/1
  • npm run lint
  • npm run format:check
  • npm run build
  • npm run typecheck
  • npx knip --workspace apps/desktop
  • npx knip --workspace packages/ui

AI use

Select exactly one:

  • No generative tool made a substantive contribution
  • Generative tooling made a substantive contribution

Tool(s) and scope: OpenAI Codex implemented the fix, tests, verification, and review-driven corrections.

Checklist

  • Tests cover the change and fail without it
  • Lint, format, typecheck and the affected suites pass locally

Does this PR entail a change in behavior?

  • Yes — described under Summary above
  • No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(desktop): proxy password editing stores the masking sentinel and corrupts credentials

1 participant