fix(desktop): prevent proxy password mask corruption - #3704
Draft
Sun-GLiang wants to merge 2 commits into
Draft
Conversation
Generated-by: OpenAI Codex
Generated-by: OpenAI Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3696
Dependency
fix/proxy-auth-test-consistency, the implementation branch for bug(desktop): proxy test drops enabled authentication when credentials are empty #3682.mainalso contains dependency commitec3b38b3c.mainafter bug(desktop): proxy test drops enabled authentication when credentials are empty #3682 lands so the PR contains onlyb94e9ab0d.Verification
npm test— all workspace tests passed; Desktop 1393/1393npm run lintnpm run format:checknpm run buildnpm run typechecknpx knip --workspace apps/desktopnpx knip --workspace packages/uiAI use
Select exactly one:
Tool(s) and scope: OpenAI Codex implemented the fix, tests, verification, and review-driven corrections.
Checklist
Does this PR entail a change in behavior?