Skip to content

feat(runtime): add plugin composition foundation #3250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
likun666661 merged 2 commits into from
Aug 24, 2026
Merged

feat(runtime): add plugin composition foundation #3250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef14700
feat(runtime): add plugin composition foundation
xxhZs Aug 20, 2026
7a7acf5
fix(runtime): harden composition foundation invariants
xxhZs Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/runtime/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,9 @@
"./path-containment": "./dist/path-containment.js",
"./plan-mode": "./dist/plan-mode.js",
"./plan-tools": "./dist/plan-tools.js",
"./plugin-composition-loader": "./dist/plugin-composition-loader.js",

@Astro-Han Astro-Han Aug 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scope objection rather than a defect, so no P level. These three subpath exports publish MakaCompositionLoader and the whole plugin-runtime surface as public contracts of @maka/runtime, and at this head nothing in the repository imports either module except the loader's own test file — only plugin-kernel.ts has a real consumer (extension-kernel.ts:1058-1064). This is the same objection as the open thread on packages/runtime-host/src/server/index.ts:12 ("Add the barrel exports in the PR that wires a consumer"), reappearing in a new package. Publishing an export is the hardest thing here to walk back later. Confirmed by reading the diff and the source at this head.

"./plugin-kernel": "./dist/plugin-kernel.js",
"./plugin-runtime": "./dist/plugin-runtime.js",
"./process-tree-terminator": "./dist/process-tree-terminator.js",
"./provider-request-telemetry": "./dist/provider-request-telemetry.js",
"./request-customization-fetch": "./dist/request-customization-fetch.js",
Expand Down
Loading