Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ import scala.concurrent.{ExecutionContext, Future}
import org.mockito.ArgumentCaptor
import org.mockito.Matchers.{eq => meq, _}
import org.mockito.Mockito._
import org.scalatest.{BeforeAndAfterAll, FunSpecLike}
import org.scalatest.BeforeAndAfterAll
import org.scalatest.funspec.AnyFunSpecLike
import org.scalatra.LifeCycle
import org.scalatra.servlet.ScalatraListener

Expand All @@ -49,7 +50,7 @@ import org.apache.livy.utils.AppInfo
* module, which implements the client session backend. The client servlet has some functionality
* overridden to avoid creating sub-processes for each seession.
*/
class HttpClientSpec extends FunSpecLike with BeforeAndAfterAll with LivyBaseUnitTestSuite {
class HttpClientSpec extends AnyFunSpecLike with BeforeAndAfterAll with LivyBaseUnitTestSuite {

import HttpClientSpec._

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,15 +25,16 @@ import org.eclipse.jetty.security._
import org.eclipse.jetty.security.UserStore
import org.eclipse.jetty.security.authentication.BasicAuthenticator
import org.eclipse.jetty.util.security._
import org.scalatest.{BeforeAndAfterAll, FunSpecLike}
import org.scalatest.Matchers._
import org.scalatest.BeforeAndAfterAll
import org.scalatest.funspec.AnyFunSpecLike
import org.scalatest.matchers.should.Matchers._
import org.scalatra.servlet.ScalatraListener

import org.apache.livy.{LivyBaseUnitTestSuite, LivyConf}
import org.apache.livy.client.common.TestUtils
import org.apache.livy.server.WebServer

class LivyConnectionSpec extends FunSpecLike with BeforeAndAfterAll with LivyBaseUnitTestSuite {
class LivyConnectionSpec extends AnyFunSpecLike with BeforeAndAfterAll with LivyBaseUnitTestSuite {
describe("LivyConnection") {
def basicAuth(username: String, password: String, realm: String): SecurityHandler = {
val roles = Array("user")
Expand Down
4 changes: 2 additions & 2 deletions core/src/test/scala/org/apache/livy/EOLUtilsSuite.scala
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@

package org.apache.livy

import org.scalatest.FunSuite
import org.scalatest.funsuite.AnyFunSuite

class EOLUtilsSuite extends FunSuite with LivyBaseUnitTestSuite {
class EOLUtilsSuite extends AnyFunSuite with LivyBaseUnitTestSuite {

test("check EOL") {
val s1 = "test\r\ntest"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,11 @@ import org.apache.http.client.params.AuthPolicy
import org.apache.http.impl.auth.BasicSchemeFactory
import org.apache.http.impl.auth.SPNegoSchemeFactory
import org.apache.http.impl.client.DefaultHttpClient
import org.scalatest._
import org.scalatest.BeforeAndAfterAll
import org.scalatest.funsuite.AnyFunSuite
import org.scalatest.matchers.should.Matchers

abstract class BaseIntegrationTestSuite extends FunSuite with Matchers with BeforeAndAfterAll {
abstract class BaseIntegrationTestSuite extends AnyFunSuite with Matchers with BeforeAndAfterAll {
import scala.concurrent.ExecutionContext.Implicits.global

var cluster: Cluster = _
Expand Down
24 changes: 21 additions & 3 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -98,12 +98,21 @@
<libthrift.version>0.9.3</libthrift.version>
<log4j.version>2.26.0</log4j.version>
<kryo.version>4.0.2</kryo.version>
<metrics.version>3.1.0</metrics.version>
<!-- Scalatra 2.8.x pulls in metrics-servlets 4.2.x; keeping metrics-core
and metrics-healthchecks on 3.1.0 causes a NoClassDefFoundError for
HealthCheckFilter at runtime (the class moved in Dropwizard 4.x). -->
<metrics.version>4.2.19</metrics.version>
<mockito.version>1.10.19</mockito.version>
<netty.version>4.1.86.Final</netty.version>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<scalatest.version>3.0.8</scalatest.version>
<scalatra.version>2.6.5</scalatra.version>
<!-- Scalatest 3.2.9 is required by Scalatra 2.8.x (needed for Scala
2.13 support). All test suites are written against the 3.2 API,
where types like `FunSuite`/`Matchers` moved into subpackages. -->
<scalatest.version>3.2.9</scalatest.version>
<!-- The scalatestplus mockito artifact uses a four-part version that tracks
scalatest (e.g. 3.2.9.0 for scalatest 3.2.9). -->
<scalatestplus.mockito.version>3.2.9.0</scalatestplus.mockito.version>
<scalatra.version>2.8.4</scalatra.version>
<java.version>1.8</java.version>
<owasp.version>12.1.9</owasp.version>
<extraJavaTestArgs>
Expand Down Expand Up @@ -263,6 +272,15 @@
<scope>test</scope>
</dependency>

<!-- ScalaTest 3.2 moved `MockitoSugar.mock` into a separate scalatestplus
artifact. -->
<dependency>
<groupId>org.scalatestplus</groupId>
<artifactId>mockito-3-4_${scala.binary.version}</artifactId>
<version>${scalatestplus.mockito.version}</version>
<scope>test</scope>
</dependency>

<dependency>
<groupId>org.scalatra</groupId>
<artifactId>scalatra-scalatest_${scala.binary.version}</artifactId>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,12 @@

package org.apache.livy.repl

import org.scalatest._
import org.scalatest.funspec.AnyFunSpec
import org.scalatest.matchers.should.Matchers

import org.apache.livy.LivyBaseUnitTestSuite

class SparkInterpreterSpec extends FunSpec with Matchers with LivyBaseUnitTestSuite {
class SparkInterpreterSpec extends AnyFunSpec with Matchers with LivyBaseUnitTestSuite {
describe("SparkInterpreter") {
val interpreter = new SparkInterpreter(null)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,12 @@

package org.apache.livy.repl

import org.scalatest.{FlatSpec, Matchers}
import org.scalatest.flatspec.AnyFlatSpec
import org.scalatest.matchers.should.Matchers

import org.apache.livy.LivyBaseUnitTestSuite

abstract class BaseInterpreterSpec extends FlatSpec with Matchers with LivyBaseUnitTestSuite {
abstract class BaseInterpreterSpec extends AnyFlatSpec with Matchers with LivyBaseUnitTestSuite {

def createInterpreter(): Interpreter

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,9 @@ import scala.language.postfixOps

import org.apache.spark.SparkConf
import org.json4s._
import org.scalatest.{FlatSpec, Matchers}
import org.scalatest.concurrent.Eventually._
import org.scalatest.flatspec.AnyFlatSpec
import org.scalatest.matchers.should.Matchers

import org.apache.livy.LivyBaseUnitTestSuite
import org.apache.livy.client.common.TestUtils
Expand All @@ -36,7 +37,7 @@ import org.apache.livy.rsc.driver.{Statement, StatementState}
import org.apache.livy.sessions._

abstract class BaseSessionSpec(kind: Kind)
extends FlatSpec with Matchers with LivyBaseUnitTestSuite {
extends AnyFlatSpec with Matchers with LivyBaseUnitTestSuite {

implicit val formats = DefaultFormats

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,10 @@ package org.apache.livy.repl
import org.apache.spark.SparkConf
import org.json4s.{DefaultFormats, JNull, JValue}
import org.json4s.JsonDSL._
import org.scalatest._
import org.scalatest.{BeforeAndAfterAll, Outcome}
import org.scalatest.Inside.inside
import org.scalatest.funspec.AnyFunSpec
import org.scalatest.matchers.should.Matchers

import org.apache.livy.rsc.driver.SparkEntries
import org.apache.livy.sessions._
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,9 @@ package org.apache.livy.repl

import org.json4s.Extraction
import org.json4s.jackson.JsonMethods.parse
import org.scalatest._
import org.scalatest.{BeforeAndAfterAll, Outcome}
import org.scalatest.funspec.AnyFunSpec
import org.scalatest.matchers.should.Matchers

import org.apache.livy.sessions._

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,15 +26,15 @@ import scala.language.postfixOps
import org.apache.spark.launcher.SparkLauncher
import org.json4s._
import org.json4s.jackson.JsonMethods._
import org.scalatest.FunSuite
import org.scalatest.concurrent.Eventually._
import org.scalatest.funsuite.AnyFunSuite

import org.apache.livy._
import org.apache.livy.client.common.TestUtils
import org.apache.livy.rsc.{PingJob, RSCClient, RSCConf}
import org.apache.livy.sessions.Spark

class ReplDriverSuite extends FunSuite with LivyBaseUnitTestSuite {
class ReplDriverSuite extends AnyFunSuite with LivyBaseUnitTestSuite {

private implicit val formats = DefaultFormats

Expand Down
8 changes: 5 additions & 3 deletions repl/src/test/scala/org/apache/livy/repl/SessionSpec.scala
Original file line number Diff line number Diff line change
Expand Up @@ -21,17 +21,19 @@ import java.util.Properties
import java.util.concurrent.{ConcurrentLinkedQueue, CountDownLatch, TimeUnit}

import org.apache.spark.SparkConf
import org.scalatest.{BeforeAndAfter, FunSpec}
import org.scalatest.Matchers._
import org.scalatest.BeforeAndAfter
import org.scalatest.concurrent.Eventually
import org.scalatest.funspec.AnyFunSpec
import org.scalatest.matchers.should.Matchers._
import org.scalatest.time._

import org.apache.livy.LivyBaseUnitTestSuite
import org.apache.livy.repl.Interpreter.ExecuteResponse
import org.apache.livy.rsc.RSCConf
import org.apache.livy.sessions._

class SessionSpec extends FunSpec with Eventually with LivyBaseUnitTestSuite with BeforeAndAfter {
class SessionSpec extends AnyFunSpec with Eventually
with LivyBaseUnitTestSuite with BeforeAndAfter {
override implicit val patienceConfig =
PatienceConfig(timeout = scaled(Span(30, Seconds)), interval = scaled(Span(100, Millis)))

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,9 @@ package org.apache.livy.repl
import org.apache.spark.SparkConf
import org.json4s.DefaultFormats
import org.json4s.JsonDSL._
import org.scalatest._
import org.scalatest.{BeforeAndAfterAll, Outcome}
import org.scalatest.funspec.AnyFunSpec
import org.scalatest.matchers.should.Matchers

import org.apache.livy.rsc.driver.SparkEntries

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,15 @@ import scala.util.{Failure, Success}

import org.apache.spark.SparkFiles
import org.apache.spark.launcher.SparkLauncher
import org.scalatest.{BeforeAndAfter, FunSuite}
import org.scalatest.BeforeAndAfter
import org.scalatest.concurrent.ScalaFutures
import org.scalatest.funsuite.AnyFunSuite

import org.apache.livy.LivyBaseUnitTestSuite
import org.apache.livy.client.common.TestUtils
import org.apache.livy.rsc.RSCConf.Entry._

class ScalaClientTest extends FunSuite
class ScalaClientTest extends AnyFunSuite
with ScalaFutures
with BeforeAndAfter
with LivyBaseUnitTestSuite {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,13 @@ import java.util.concurrent.{CountDownLatch, TimeUnit}
import scala.collection.mutable.ArrayBuffer
import scala.concurrent.{Await, Future}
import scala.concurrent.duration._
import scala.language.postfixOps

import org.scalatest.FunSuite
import org.scalatest.funsuite.AnyFunSuite

import org.apache.livy.LivyBaseUnitTestSuite

object ScalaClientTestUtils extends FunSuite with LivyBaseUnitTestSuite {
object ScalaClientTestUtils extends AnyFunSuite with LivyBaseUnitTestSuite {

val Timeout = 40

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,14 @@ import scala.util.{Failure, Success}

import org.mockito.Matchers._
import org.mockito.Mockito._
import org.scalatest.{BeforeAndAfter, FunSuite}
import org.scalatest.BeforeAndAfter
import org.scalatest.concurrent.ScalaFutures
import org.scalatest.funsuite.AnyFunSuite

import org.apache.livy.{JobHandle, LivyBaseUnitTestSuite}
import org.apache.livy.JobHandle.{Listener, State}

class ScalaJobHandleTest extends FunSuite
class ScalaJobHandleTest extends AnyFunSuite
with ScalaFutures
with BeforeAndAfter
with LivyBaseUnitTestSuite {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,12 @@

package org.apache.livy.server

import org.scalatest.{FunSuite, Matchers}
import org.scalatest.funsuite.AnyFunSuite
import org.scalatest.matchers.should.Matchers

import org.apache.livy.{LivyBaseUnitTestSuite, LivyConf}

class AccessManagerSuite extends FunSuite with Matchers with LivyBaseUnitTestSuite {
class AccessManagerSuite extends AnyFunSuite with Matchers with LivyBaseUnitTestSuite {
import LivyConf._

private val viewUsers = Seq("user1", "user2", "user3")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,14 @@ package org.apache.livy.server

import javax.servlet.http.HttpServletResponse

import org.scalatest.FunSpecLike
import org.scalatest.funspec.AnyFunSpecLike
import org.scalatra.ScalatraServlet
import org.scalatra.test.scalatest.ScalatraSuite

import org.apache.livy.LivyBaseUnitTestSuite

class ApiVersioningSupportSpec extends ScalatraSuite with FunSpecLike with LivyBaseUnitTestSuite {
class ApiVersioningSupportSpec extends ScalatraSuite with AnyFunSpecLike
with LivyBaseUnitTestSuite {
val LatestVersionOutput = "latest"

object FakeApiVersions extends Enumeration {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import javax.servlet.http.HttpServletResponse._
import scala.reflect.ClassTag

import com.fasterxml.jackson.databind.ObjectMapper
import org.scalatest.FunSpecLike
import org.scalatest.funspec.AnyFunSpecLike
import org.scalatra.test.scalatest.ScalatraSuite

import org.apache.livy.LivyBaseUnitTestSuite
Expand All @@ -38,7 +38,7 @@ import org.apache.livy.LivyBaseUnitTestSuite
* `Unit`, and the `response` object should be checked directly.
*/
abstract class BaseJsonServletSpec extends ScalatraSuite
with FunSpecLike with LivyBaseUnitTestSuite {
with AnyFunSpecLike with LivyBaseUnitTestSuite {

protected val mapper = new ObjectMapper()
.registerModule(com.fasterxml.jackson.module.scala.DefaultScalaModule)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,13 @@ import javax.servlet.http.{HttpServletRequest, HttpServletResponse}

import org.mockito.ArgumentCaptor
import org.mockito.Mockito.{atLeastOnce, verify}
import org.scalatest.{FunSpec, Matchers}
import org.scalatest.funspec.AnyFunSpec
import org.scalatest.matchers.should.Matchers
import org.scalatestplus.mockito.MockitoSugar.mock

import org.apache.livy.{LivyBaseUnitTestSuite, LivyConf}

class SecurityHeadersFilterSpec extends FunSpec with Matchers with LivyBaseUnitTestSuite {
class SecurityHeadersFilterSpec extends AnyFunSpec with Matchers with LivyBaseUnitTestSuite {

val requiredHeaders = Set("X-Content-Type-Options", "X-Frame-Options", "X-XSS-Protection",
"Content-Security-Policy")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@ import scala.concurrent.duration.Duration
import org.mockito.Matchers
import org.mockito.Matchers.anyObject
import org.mockito.Mockito._
import org.scalatest.{BeforeAndAfter, FunSpec}
import org.scalatest.BeforeAndAfter
import org.scalatest.funspec.AnyFunSpec
import org.scalatestplus.mockito.MockitoSugar.mock

import org.apache.livy.{LivyBaseUnitTestSuite, LivyConf, Utils}
Expand All @@ -36,9 +37,9 @@ import org.apache.livy.sessions.SessionState
import org.apache.livy.utils.{AppInfo, Clock, SparkApp}

class BatchSessionSpec
extends FunSpec
extends AnyFunSpec
with BeforeAndAfter
with org.scalatest.Matchers
with org.scalatest.matchers.should.Matchers
with LivyBaseUnitTestSuite {

val script: Path = {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,11 @@
package org.apache.livy.server.batch

import com.fasterxml.jackson.databind.{JsonMappingException, ObjectMapper}
import org.scalatest.FunSpec
import org.scalatest.funspec.AnyFunSpec

import org.apache.livy.LivyBaseUnitTestSuite

class CreateBatchRequestSpec extends FunSpec with LivyBaseUnitTestSuite {
class CreateBatchRequestSpec extends AnyFunSpec with LivyBaseUnitTestSuite {

private val mapper = new ObjectMapper()
.registerModule(com.fasterxml.jackson.module.scala.DefaultScalaModule)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,12 @@
package org.apache.livy.server.interactive

import com.fasterxml.jackson.databind.ObjectMapper
import org.scalatest.FunSpec
import org.scalatest.funspec.AnyFunSpec

import org.apache.livy.LivyBaseUnitTestSuite
import org.apache.livy.sessions.{PySpark, SessionKindModule}

class CreateInteractiveRequestSpec extends FunSpec with LivyBaseUnitTestSuite {
class CreateInteractiveRequestSpec extends AnyFunSpec with LivyBaseUnitTestSuite {

private val mapper = new ObjectMapper()
.registerModule(com.fasterxml.jackson.module.scala.DefaultScalaModule)
Expand Down
Loading