KAFKA-19782: Improve perfomance Authorizer.authorizeByResourceType by using Prefix Trie#20912
KAFKA-19782: Improve perfomance Authorizer.authorizeByResourceType by using Prefix Trie#20912ekuvardin wants to merge 17 commits into
Conversation
|
A label of 'needs-attention' was automatically added to this PR in order to raise the |
|
A label of 'needs-attention' was automatically added to this PR in order to raise the |
# Conflicts: # jmh-benchmarks/src/main/java/org/apache/kafka/jmh/acl/AuthorizeByResourceTypeSearch.java
|
A label of 'needs-attention' was automatically added to this PR in order to raise the |
# Conflicts: # gradle/dependencies.gradle
|
A label of 'needs-attention' was automatically added to this PR in order to raise the |
| - caffeine-3.2.0 | ||
| - commons-beanutils-1.11.0 | ||
| - commons-collections-3.2.2 | ||
| - commons-collections4-4.5.0 |
There was a problem hiding this comment.
not 100% sure introducing a new client dependency is a good idea
There was a problem hiding this comment.
I tried to find a PrefixTrie or PatriciaTrie in the libraries we already use, but without success.
I don’t consider writing our own implementation to be a good idea.
What makes the situation even worse is that we already have a version of commons-collections-3.2.2 used somewhere deep in the codebase, but it is not compatible with the newer commons-collections4-4.5.0 (they even split it into a separate “4” module specifically because of this).
If you have any other ideas, please drop me a message in my profile email. I will arrange meeting
There was a problem hiding this comment.
@Nikita-Shupletsov Shall we discuss this dependency with a wider group?
|
Related PR with different approach: #20911 |
# Conflicts: # gradle/dependencies.gradle
|
@apoorvmittal10 could you please review this PR? |
https://issues.apache.org/jira/browse/KAFKA-19782