feat: add PrimitiveType::Variant to iceberg spec#2423
Open
Shekharrajak wants to merge 9 commits into
Open
Conversation
Shekharrajak
force-pushed
the
feat/variant-primitive-type
branch
from
6c6f490 to
6265b88
Compare
Shekharrajak
force-pushed
the
feat/variant-primitive-type
branch
from
6265b88 to
3c86956
Compare
Contributor
Author
|
This have some overlap with #2188 but its is minimal start. |
Shekharrajak
changed the title
Shekharrajak
force-pushed
the
feat/variant-primitive-type
branch
from
b581777 to
3c86956
Compare
Contributor
Author
|
I have followup changes in progress : |
Contributor
Author
|
Final plan: |
nssalian
suggested changes
May 15, 2026
Shekharrajak
force-pushed
the
feat/variant-primitive-type
branch
from
00019c9 to
14e91d5
Compare
Shekharrajak
commented
May 19, 2026
| Ok(glue_type) | ||
| } | ||
|
|
||
| fn variant(&mut self, _v: &iceberg::spec::VariantType) -> iceberg::Result<String> { |
Contributor
Author
There was a problem hiding this comment.
We will work on this in follow up PRs
Shekharrajak
commented
May 19, 2026
| Ok(hive_type) | ||
| } | ||
|
|
||
| fn variant(&mut self, _v: &iceberg::spec::VariantType) -> iceberg::Result<String> { |
Contributor
Author
There was a problem hiding this comment.
We will work on this in follow up PRs
Shekharrajak
commented
May 19, 2026
| ) -> crate::Result<ArrowSchemaOrFieldOrType> { | ||
| Err(crate::Error::new( | ||
| crate::ErrorKind::FeatureUnsupported, | ||
| "Arrow schema conversion for Variant is not yet implemented", |
Contributor
Author
There was a problem hiding this comment.
We will work on this in follow up PRs
Shekharrajak
commented
May 19, 2026
| fn variant(&mut self, _v: &VariantType, _partner: &ArrayRef) -> Result<Vec<Option<Literal>>> { | ||
| Err(Error::new( | ||
| ErrorKind::FeatureUnsupported, | ||
| "Arrow value extraction for Variant is not yet implemented", |
Contributor
Author
There was a problem hiding this comment.
We will work on this in follow up PRs
Shekharrajak
commented
May 19, 2026
| } else { | ||
| self.name_to_id.insert(full_name, field_id); | ||
| } | ||
| self.insert_current_path() |
Contributor
Author
There was a problem hiding this comment.
just a refactor
Contributor
Author
|
Updated the branch Please have a look @nssalian @mbutrovich |
16 tasks
Contributor
|
@Shekharrajak is this the same as #2188? That change has one approval already. |
Collaborator
|
I think we should rally behind #2188 since it's already gone through review rounds and is approved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
#2411
What changes are included in this PR?
• Adds PrimitiveType::Variant to the Iceberg type system (spec v3)
• Implements Display — serializes as "variant" per Iceberg spec
• Implements compatible() — returns false for all literals (no scalar predicate against Variant)
• Adds Avro mapping — AvroSchema::Bytes (opaque, no natural Avro equivalent)
• Adds PrimitiveType::Variant to the canonical primitive_type_serde test
• Adds targeted tests: Display output, serde round-trip, literal incompatibility
Are these changes tested?
Unit tests
What this PR does NOT do (follow-up):
• Arrow schema mapping (DataType::Struct + VariantType extension)
• arrow_field_to_type reverse mapping
• Metrics evaluator statistics suppression
• Iceberg scan/write path support