fix(hadoop): publish metadata without replacing existing files#1325
Closed
fallintoplace wants to merge 1 commit into
Closed
fix(hadoop): publish metadata without replacing existing files#1325fallintoplace wants to merge 1 commit into
fallintoplace wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
CreateTable and CommitTable currently stage metadata to a temp file and then rename it into place. On POSIX, rename can replace an existing destination, so a concurrent writer that publishes the same metadata version first can still be overwritten by the loser.
Using link(temp, final) keeps the publish step atomic while making an existing destination fail with ErrExist instead of being replaced.
Testing