fix: use transform equality for partition compatibility#1314
Open
fallintoplace wants to merge 2 commits into
Open
fix: use transform equality for partition compatibility#1314fallintoplace wants to merge 2 commits into
fallintoplace wants to merge 2 commits into
Conversation
zeroshade
approved these changes
Jun 26, 2026
zeroshade
left a comment
zeroshade
left a comment
Member
There was a problem hiding this comment.
LGTM. Switching CompatibleWith from interface identity to Transform.Equals is correct, aligns with PartitionField.Equals, and removes the panic risk on non-comparable transforms. One optional coverage nit inline.
| assert.Equal(t, 1002, spec3.LastAssignedFieldID()) | ||
| } | ||
|
|
||
| func TestPartitionSpecCompatibleWithUsesTransformEquals(t *testing.T) { |
Member
There was a problem hiding this comment.
nit: this nicely pins the non-comparable custom-transform path. It'd be worth also asserting the built-in parameterized cases directly at the CompatibleWith level - e.g. bucket[16] vs bucket[32] and truncate[4] vs truncate[8] should be incompatible, while identical transforms stay compatible. They work today via the built-in Equals impls, but a couple of table-driven cases here would guard against regressions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
PartitionField.Equals already delegates transform comparison to Transform.Equals, but PartitionSpec.CompatibleWith compared transform interfaces directly. That can panic for non-comparable transform implementations and also bypass transform-specific equality semantics.
Testing