fix(partition-ttl): Fix the integer overflow issue when TTL exceeded 24 days.

[wangxianghu]

Describe the issue this Pull Request addresses

when days to retain is bigger than 24, then writeConfig.getPartitionTTLStrategyDaysRetain() * 1000 * 3600 * 24 > Integer.MAX_VALUE, ttlInMilis <= 0 will always be true

org.apache.hudi.table.action.ttl.strategy.KeepByTimeStrategy#getExpiredPartitionPaths always return empty list.

    if (!lastCompletedInstant.isPresent() || ttlInMilis <= 0
        || !hoodieTable.getMetaClient().getTableConfig().getPartitionFields().isPresent()) {
      return Collections.emptyList();
    }

cast writeConfig.getPartitionTTLStrategyDaysRetain() to long can fix it

this.ttlInMilis = (long) writeConfig.getPartitionTTLStrategyDaysRetain() * 1000 * 3600 * 24;

Summary and Changelog

Fix daysReatain> 24 integer overflow issue

Impact

None

Risk Level

low

Documentation Update

None

Contributor's checklist

• Read through contributor's guide
• Enough context is provided in the sections above
• Adequate tests were added if applicable

[hudi-agent]

⚠️ 🤖 This review was generated by an AI agent and may contain mistakes. Please verify any suggestions before applying.

Thanks for the contribution! This PR fixes an integer overflow in KeepByTimeStrategy where daysRetain > 24 caused ttlInMilis to go negative, making getExpiredPartitionPaths always return an empty list. The (long) cast correctly promotes the multiplication to long arithmetic, and the added test covers the overflow boundary well. No correctness issues found. A few style/readability suggestions in the inline comments. Please take a look, and this should be ready for a Hudi committer or PMC member to take it from here. One simplification suggestion for the production-side fix — the test coverage is solid.

cc @yihua

[hudi-bot]

CI report:

• 3976e15 Azure: SUCCESS

Bot commands

@hudi-bot supports the following commands:

• @hudi-bot run azure re-run the last Azure build