Improvements to Git integration #6914

[nadment]

This PR isn't ready for a merge yet; I'm just looking for feedback.

[mattcasters]

I really like the 2 new perspectives: commit and git.
Current functionality seems to work.
I like the graph view in the git perspective. I would love to see the "Visual Difference" option as a toolbar button when selecting a commit and a file in the graph tree.

[nadment]

Visual Diff appears as a button in the toolbar

[mattcasters]

I built and tested the new perspectives and I absoutely love this work. Congrats.

[mattcasters]

It should be easy to disable the 2 new perspectives in Hop Web until we find an alternative. Perhaps we can create a ticket for that separately.

[hansva]

Yes, if we want to ship this with 2.18 then that will be the best approach, I'd like to start the code freeze and a 2 week hardening/test period as we have done a massive amount of work.

[nadment]

I need to restore the commit function in GitGuiPlugin which is available in the file explorer for Hop web.

[hansva]

Right it's not as simple as just disabling the new views

[hansva]

But is the entire view jface or just specific elements that we could disable for hop web?

[nadment]

If we don't load the two perspectives in web mode (a hard-coded filter in HopGui until the next version) and I restore the menu/toolitem for the commit, it might work

[mattcasters]

If we don't load the two perspectives in web mode (a hard-coded filter in HopGui until the next version) and I restore the menu/toolitem for the commit, it might work

Exactly what I was thinking. Perhaps we can add an option in the annotation driving the perspective plugins for now.

@HopPerspectivePlugin something like boolean ignoreOnHopWeb() default false;