fix(python): correct primitive list byte-length serialization#3570
Open
utafrali wants to merge 1 commit intoapache:mainfrom
Open
fix(python): correct primitive list byte-length serialization#3570utafrali wants to merge 1 commit intoapache:mainfrom
utafrali wants to merge 1 commit intoapache:mainfrom
Conversation
Collaborator
|
Please create pr from latest main branch. And we also need a python test between list and tuple |
Contributor
Author
|
Got it, I'll rebase from latest main and add the list vs tuple test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution Checklist
Why?
Fixes #3506
Rust and Python had a mismatch in how they serialize list lengths for fixed-size primitive types. Python was writing element count, but Rust expects byte length. This broke deserialization when reading INT16, INT32, or FLOAT64 lists.
What does this PR do?
Added a helper function to identify types that need byte-length encoding (INT16, INT32, FLOAT64) and updated the serialization logic to write byte count instead of element count for fixed-size types without nulls.
Related issues
Closes #3506
User-facing changes
N/A
Benchmark
N/A