Skip to content

feat(triple) Remove protocol/grpc from the project#3455

Open
Alanxtl wants to merge 2 commits into
apache:developfrom
Alanxtl:remove_grpc
Open

feat(triple) Remove protocol/grpc from the project#3455
Alanxtl wants to merge 2 commits into
apache:developfrom
Alanxtl:remove_grpc

Conversation

@Alanxtl

@Alanxtl Alanxtl commented Jun 26, 2026

Copy link
Copy Markdown
Member

Description

close #2894

!! BREAKING CHANGE: Although dubbo-go does not use protocol/grpc internally, downstream users can use it directly. This will make it usable.

Checklist

  • I confirm the target branch is develop
  • Code has passed local testing
  • I have added tests that prove my fix is effective or that my feature works

@Alanxtl Alanxtl linked an issue Jun 26, 2026 that may be closed by this pull request
@codecov-commenter

codecov-commenter commented Jun 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 145 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.18%. Comparing base (8b5bbcf) to head (b6dd9f6).
⚠️ Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
...ocol/internal/gen/proto/connect/ping/v1/ping.pb.go 0.00% 74 Missing ⚠️
...nternal/gen/proto/connect/collide/v1/collide.pb.go 0.00% 26 Missing ⚠️
...ernal/proto/connectext/grpc/status/v1/status.pb.go 0.00% 20 Missing ⚠️
...rnal/interoperability/interop.triple_wrapper.pb.go 0.00% 10 Missing ⚠️
.../internal/gen/proto/connect/import/v1/import.pb.go 0.00% 9 Missing ⚠️
...l/gen/proto/connectext/grpc/status/v1/status.pb.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3455      +/-   ##
===========================================
+ Coverage    53.57%   56.18%   +2.61%     
===========================================
  Files          460      445      -15     
  Lines        35182    33731    -1451     
===========================================
+ Hits         18847    18952     +105     
+ Misses       14857    13300    -1557     
- Partials      1478     1479       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud

Copy link
Copy Markdown

@Alanxtl Alanxtl changed the title Remove protocol/grpc from the project feat(triple) Remove protocol/grpc from the project Jun 27, 2026
@Alanxtl Alanxtl added 4.0.0 version 4.0.0 and removed 3.3.2 version 3.3.2 labels Jun 28, 2026
@CAICAIIs

Copy link
Copy Markdown
Contributor

tools/dubbo-go-schema/dubbo-go.json 仍把 protocol.name = "grpc" 列为合法枚举,但 PR 已删除唯一的 extension.SetProtocol("grpc", ...) 注册路径。运行时 extension.GetProtocol("grpc") 会走 MustGet,缺失时 panic:protocol for [grpc] is not existing... ,,删除的是 public protocol/grpc,schema 也应同步删掉 "grpc"

@Alanxtl

Alanxtl commented Jun 29, 2026

Copy link
Copy Markdown
Member Author

tools/dubbo-go-schema/dubbo-go.json 仍把 protocol.name = "grpc" 列为合法枚举,但 PR 已删除唯一的 extension.SetProtocol("grpc", ...) 注册路径。运行时 extension.GetProtocol("grpc") 会走 MustGet,缺失时 panic:protocol for [grpc] is not existing... ,,删除的是 public protocol/grpc,schema 也应同步删掉 "grpc"

这个我知道 我打算之后把tools统一更新一下

@CAICAIIs CAICAIIs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Delete protocol/dubbo3 and protocol/grpc

3 participants