fix(remoting): clean up pendingResponses on error paths to prevent map leak

remoting/exchange.go

@@ -184,6 +184,12 @@ func removePendingResponse(seq SequenceType) *PendingResponse {
 	return nil
 }
 
+// RemovePendingResponse removes and returns the pending response for the given sequence ID.
+// It is the exported version of removePendingResponse for use by external packages.
+func RemovePendingResponse(seq SequenceType) *PendingResponse {
+	return removePendingResponse(seq)
+}
+
 // GetPendingResponse gets the response
 func GetPendingResponse(seq SequenceType) *PendingResponse {
 	if presp, ok := pendingResponses.Load(seq); ok {

remoting/exchange_client.go

@@ -132,6 +132,7 @@ func (client *ExchangeClient) Request(invocation *base.Invocation, url *common.U
 	err := client.client.Request(request, timeout, rsp)
 	// request error
 	if err != nil {
+		removePendingResponse(SequenceType(request.ID))
 		res.Err = err
 		return err
 	}
@@ -165,6 +166,7 @@ func (client *ExchangeClient) AsyncRequest(invocation *base.Invocation, url *com
 
 	err := client.client.Request(request, timeout, rsp)
 	if err != nil {
+		removePendingResponse(SequenceType(request.ID))
 		result.Err = err
 		return err
 	}

remoting/getty/listener.go

@@ -354,6 +354,7 @@ func heartbeat(session getty.Session, timeout time.Duration, callBack func(err e
 		select {
 		case <-gxtime.After(timeout):
 			err1 = errHeartbeatReadTimeout
+			remoting.RemovePendingResponse(remoting.SequenceType(req.ID))
 		case <-resp.Done:
 			err1 = resp.Err
 		}