Skip to content

[branch-4.0](scan) remove SchemaCache to fix concurrent crash in OlapScanner::prepare (#62327)#62427

Merged
yiguolei merged 1 commit intoapache:branch-4.0from
csun5285:pick-62327-to-4.0
Apr 15, 2026
Merged

[branch-4.0](scan) remove SchemaCache to fix concurrent crash in OlapScanner::prepare (#62327)#62427
yiguolei merged 1 commit intoapache:branch-4.0from
csun5285:pick-62327-to-4.0

Conversation

@csun5285
Copy link
Copy Markdown
Contributor

pick from master #62327

@csun5285
Copy link
Copy Markdown
Contributor Author

run buildall

@csun5285 csun5285 changed the title [refactor](scan) remove SchemaCache to fix concurrent crash in OlapScanner::prepare (#62327) [branch-4.0](scan) remove SchemaCache to fix concurrent crash in OlapScanner::prepare (#62327) Apr 13, 2026
…anner::prepare (apache#62327)

Remove SchemaCache entirely. Each scanner now always builds its own
independent TabletSchema via `std::make_shared<TabletSchema>()`,
eliminating shared mutable state between concurrent scanners.

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

None

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [x] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
(cherry picked from commit aa1e21d)
@csun5285 csun5285 force-pushed the pick-62327-to-4.0 branch from d625cea to c4b4828 Compare April 13, 2026 04:53
@csun5285
Copy link
Copy Markdown
Contributor Author

run buildall

@hello-stephen
Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (13/13) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.33% (25380/35583)
Line Coverage 54.02% (267645/495466)
Region Coverage 51.64% (221702/429331)
Branch Coverage 53.05% (95396/179830)

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Apr 15, 2026
@github-actions
Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit a528fe0 into apache:branch-4.0 Apr 15, 2026
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants