[opt](fe)remove classhisto*=trace in JAVA_OPTS_FOR_JDK_17 to prevent printing class histogram in full gc#62422
Merged
englefly merged 1 commit intoapache:masterfrom Apr 15, 2026
Merged
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
…printing class histogram in full gc
45d7d75 to
dc22034
Compare
Contributor
Author
|
run buildall |
Contributor
Author
|
/review |
Contributor
There was a problem hiding this comment.
Blocking issue found.
conf/fe.confremovesclasshisto*=trace, but the same FE JDK 17 option is still present in the functionally parallel templates underregression-test/pipeline/*/conf/fe.confandregression-test/pipeline/nonConcurrent/conf/fe.conf. Those environments still start FE with class histogram tracing enabled, so the PR does not fully accomplish its stated goal.
Critical checkpoint conclusions:
- Goal of the task: Partially met. The main
conf/fe.confpath is fixed, but equivalent FE startup config templates still keep the old flag, so the noisy full-GC logging remains in other supported paths. No test is included to prove all affected startup configs are covered. - Small, clear, focused modification: Yes, but too narrow for the stated behavior change.
- Concurrency: Not applicable; this is a static shell config change.
- Lifecycle/static initialization: Not applicable.
- Configuration items added: No new config item was added.
- Incompatible changes: None identified.
- Functionally parallel code paths: Not handled completely. Equivalent FE config templates under regression/pipeline still diverge from
conf/fe.conf. - Special conditional checks: Not applicable.
- Test coverage: Insufficient for this kind of config consistency change; no verification that other FE startup templates were updated.
- Observability: Acceptable; reducing GC log verbosity is the intended change.
- Transaction/persistence: Not applicable.
- Data writes/modifications: Not applicable.
- FE/BE variable passing: Not applicable.
- Performance: The intended optimization is sound, but incomplete because unchanged templates still pay the class histogram logging cost.
- Other issues: None beyond the missed parallel paths.
Please update the remaining FE config templates that carry the same JAVA_OPTS_FOR_JDK_17 setting so behavior is consistent across the supported environments.
others are for pipeline test. Keep it as it is
englefly
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)