Skip to content

[opt](fe)remove classhisto*=trace in JAVA_OPTS_FOR_JDK_17 to prevent printing class histogram in full gc#62422

Merged
englefly merged 1 commit intoapache:masterfrom
starocean999:master_0413
Apr 15, 2026
Merged

[opt](fe)remove classhisto*=trace in JAVA_OPTS_FOR_JDK_17 to prevent printing class histogram in full gc#62422
englefly merged 1 commit intoapache:masterfrom
starocean999:master_0413

Conversation

@starocean999
Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@starocean999
Copy link
Copy Markdown
Contributor Author

run buildall

@starocean999
Copy link
Copy Markdown
Contributor Author

run buildall

@starocean999
Copy link
Copy Markdown
Contributor Author

/review

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking issue found.

  1. conf/fe.conf removes classhisto*=trace, but the same FE JDK 17 option is still present in the functionally parallel templates under regression-test/pipeline/*/conf/fe.conf and regression-test/pipeline/nonConcurrent/conf/fe.conf. Those environments still start FE with class histogram tracing enabled, so the PR does not fully accomplish its stated goal.

Critical checkpoint conclusions:

  • Goal of the task: Partially met. The main conf/fe.conf path is fixed, but equivalent FE startup config templates still keep the old flag, so the noisy full-GC logging remains in other supported paths. No test is included to prove all affected startup configs are covered.
  • Small, clear, focused modification: Yes, but too narrow for the stated behavior change.
  • Concurrency: Not applicable; this is a static shell config change.
  • Lifecycle/static initialization: Not applicable.
  • Configuration items added: No new config item was added.
  • Incompatible changes: None identified.
  • Functionally parallel code paths: Not handled completely. Equivalent FE config templates under regression/pipeline still diverge from conf/fe.conf.
  • Special conditional checks: Not applicable.
  • Test coverage: Insufficient for this kind of config consistency change; no verification that other FE startup templates were updated.
  • Observability: Acceptable; reducing GC log verbosity is the intended change.
  • Transaction/persistence: Not applicable.
  • Data writes/modifications: Not applicable.
  • FE/BE variable passing: Not applicable.
  • Performance: The intended optimization is sound, but incomplete because unchanged templates still pay the class histogram logging cost.
  • Other issues: None beyond the missed parallel paths.

Please update the remaining FE config templates that carry the same JAVA_OPTS_FOR_JDK_17 setting so behavior is consistent across the supported environments.

Comment thread conf/fe.conf
@starocean999 starocean999 dismissed github-actions[bot]’s stale review April 15, 2026 06:15

others are for pipeline test. Keep it as it is

@englefly englefly merged commit 024614e into apache:master Apr 15, 2026
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants