Bugfix: HLL4 written in rust cannot not be loaded in Java#132
Merged
notfilippo merged 1 commit intoMay 19, 2026
Merged
Conversation
The aux map can be serialized in two format. Rust serializes only the compact format but omits to set the compact flag. https://github.com/apache/datasketches-java/blob/main/src/main/java/org/apache/datasketches/hll/HeapAuxHashMap.java#L65-L96 This PR sets the flag.
fulmicoton-dd
force-pushed
the
paul.masurel/bugfix-java-aux-array-compact-flag
branch
from
d5c88c9 to
bf9e177
Compare
notfilippo
approved these changes
May 19, 2026
Member
notfilippo
left a comment
notfilippo
left a comment
There was a problem hiding this comment.
Looks good to me.
@tisonkun , should we look into testing that our serialized sketches can be read correctly the Java / C++ implementation?
Member
|
@notfilippo I think we can file an issue on both repo and collaborate with perhaps @leerho and @AlexanderSaydakov to land the compatibility tests. It can be also related to our long-term idea on #10 |
Member
|
@notfilippo side note - we may use |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The aux map can be serialized in two format.
Rust serializes only the compact format but omits to set the compact flag.
https://github.com/apache/datasketches-java/blob/main/src/main/java/org/apache/datasketches/hll/HeapAuxHashMap.java#L65-L96
This PR sets the flag.