Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can drop this "Unreleased"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope. It's a stub for the next unreleased changelog. An empty "Unrelesed" section would not cause misunderstanding and it simplifies contributors to attatch changelog entries instead of the very first contributor should add an "Unreleased" heading.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it would be nice to add an HTML style comment to denote that. Thanks for the explanation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you submit a PR to add one?
It's intuitive to me when I learn this pattern from somewhere like https://github.com/open-telemetry/opentelemetry-rust/blob/b1393e31c12543e704be6d4595b3d22134c59f9b/opentelemetry-http/CHANGELOG.md.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I adopt this pattern for most of my projects, BTW (e.g., https://github.com/scopedb/scopeql/blob/2e34a2cd47f6996874e45b1ddac030f643b2abe4/CHANGELOG.md)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. Why not! Looks actually like a fairly nice approach and might enforce PR creators to also include an entry in the CHANGELOG.md so it can always be up-to-date with unreleased changes.