Skip to content

Escape constant pool names in generated HTML#500

Merged
garydgregory merged 1 commit into
apache:masterfrom
rootvector2:class2html-escape-names
Jun 12, 2026
Merged

Escape constant pool names in generated HTML#500
garydgregory merged 1 commit into
apache:masterfrom
rootvector2:class2html-escape-names

Conversation

@rootvector2

Copy link
Copy Markdown
Contributor

auditing the generated-html path surfaced that field, method, local-variable, inner-class and type/class-reference names from the constant pool are written into the Class2HTML output as element text without escaping, so a crafted .class whose pool holds a name like <script> yields stored xss in the generated pages; route them through the existing Class2HTML.toHTML that the method-name sinks already use, leaving link anchors and filenames untouched so links keep working.

  • Read the contribution guidelines for this project.
  • Read the ASF Generative Tooling Guidance if you use Artificial Intelligence (AI).
  • I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute?
  • Run a successful build using the default Maven goal with mvn; that's mvn on the command line by itself.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.

@garydgregory garydgregory changed the title escape constant pool names in generated html Escape constant pool names in generated html Jun 12, 2026
@garydgregory garydgregory changed the title Escape constant pool names in generated html Escape constant pool names in generated HTML Jun 12, 2026
@garydgregory garydgregory merged commit 9a08f93 into apache:master Jun 12, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants