CASSANDRA-19433 Nodetool cleanup can drop data Accord might need#270
Open
alanwang67 wants to merge 3 commits into
Open
CASSANDRA-19433 Nodetool cleanup can drop data Accord might need#270alanwang67 wants to merge 3 commits into
alanwang67 wants to merge 3 commits into
Conversation
aweisberg
requested changes
May 28, 2026
| } | ||
|
|
||
| private static ImmutableSortedMap<Timestamp, Ranges> purgeHistory(NavigableMap<Timestamp, Ranges> in, Ranges remove) | ||
| protected static ImmutableSortedMap<Timestamp, Ranges> purgeHistory(NavigableMap<Timestamp, Ranges> in, Ranges remove) |
Contributor
There was a problem hiding this comment.
This could be package private.
Contributor
Author
There was a problem hiding this comment.
I think setting it to package private means that we can't access it from CommandStores.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new method to get ranges owned by CommandStores to be used by
nodetool cleanupto determine when it is safe to cleanup a range.