chore: update Elasticsearch version in test configuration to 8.19.10#74
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Elasticsearch Testcontainers version used in the test profile to better match the Elastic Cloud version used by AODN.
Changes:
- Bumped the Elasticsearch Docker image tag used by test configuration to
8.19.10. - Updated the default Elasticsearch container version in
ElasticsearchTestConfig.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/test/resources/application-test.yaml |
Updates the Elasticsearch docker image version for test runs (also includes an unrelated Actuator management config change). |
src/test/java/au/org/aodn/oceancurrent/configuration/elasticsearch/ElasticsearchTestConfig.java |
Updates the default/fallback Elasticsearch container version used by Testcontainers in tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
6
to
+12
| management: | ||
| endpoint: | ||
| health: | ||
| enabled: false | ||
| access: none | ||
| endpoints: | ||
| enabled-by-default: false | ||
| access: | ||
| default: none |
Comment on lines
33
to
35
| public ElasticsearchContainer elasticsearchContainer( | ||
| @Value("${elasticsearch.docker.elasticVersion:8.17.4}") String version | ||
| @Value("${elasticsearch.docker.elasticVersion:8.19.10}") String version | ||
| ) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To align with the real elastic search cloud version for AODN