Products can be added at max stock amount - #35
Open
anttiasmala wants to merge 11 commits into
Open
Conversation
… through and add whenRequestSent attribute. Add cartItem create and update methods
…n /api/cart/index.ts
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
anttiasmala
commented
Jul 29, 2025
| createdAt: true, | ||
| updatedAt: true, | ||
| uuid: true, | ||
| stock: true, |
Owner
Author
There was a problem hiding this comment.
Omit stock from request sent to frontend for now
anttiasmala
commented
Jul 29, 2025
Comment on lines
-67
to
+73
| return res.status(200).json(cartItems); | ||
| const clonedCartItems = structuredClone(cartItems); | ||
| const newCartItems = clonedCartItems.map((clonedCartItem) => { | ||
| return { ...clonedCartItem, whenRequestSent: new Date() }; | ||
| }); | ||
|
|
||
| return res.status(200).json(newCartItems); |
Owner
Author
There was a problem hiding this comment.
StructureClone the cartItems and add newCartItems. Loop them through and add whenRequsetSent attribute. This will make GET requests differ from each other so useEffect will "grab" them
anttiasmala
commented
Jul 29, 2025
Comment on lines
-92
to
+135
| const upsertedItem = await prisma.cartItem.upsert({ | ||
| const cartItem = await prisma.cartItem.findFirst({ | ||
| where: { | ||
| cartUUID_productUUID: { | ||
| productUUID: product.uuid, | ||
| cartUUID: cart.uuid, | ||
| }, | ||
| }, | ||
| create: { | ||
| cartUUID: cart.uuid, | ||
| productUUID: product.uuid, | ||
| amount: productToBeAdded.amount, | ||
| }, | ||
| update: { | ||
| amount: { | ||
| increment: productToBeAdded.amount, | ||
| }); | ||
|
|
||
| // cartItem does not exist, create a new one | ||
| if (!cartItem) { | ||
| const createdItem = await prisma.cartItem.create({ | ||
| data: { | ||
| amount: productToBeAdded.amount, | ||
| cartUUID: cart.uuid, | ||
| productUUID: product.uuid, | ||
| }, | ||
| }); | ||
| return res.status(200).json(createdItem); | ||
| } | ||
|
|
||
| if (cartItem.amount + 1 > product.stock) { | ||
| throw new HttpError('Maximum amount of products reached!', 400); | ||
| } | ||
|
|
||
| const newAmount = | ||
| cartItem.amount >= product.stock ? product.stock : cartItem.amount + 1; | ||
|
|
||
| const updatedItem = await prisma.cartItem.update({ | ||
| where: { | ||
| cartUUID_productUUID: { | ||
| cartUUID: cart.uuid, | ||
| productUUID: product.uuid, | ||
| }, | ||
| }, | ||
| data: { | ||
| amount: newAmount, | ||
| }, | ||
| }); | ||
| return res.status(200).json(upsertedItem); | ||
| return res.status(200).json(updatedItem); |
Owner
Author
There was a problem hiding this comment.
Change upsertedItem to createdItem/updatedItem. Uses "old" method due to need to know the amount of products in cart
anttiasmala
commented
Jul 29, 2025
Comment on lines
-232
to
+242
| // this will prevent request sent to backend if amount of products were same | ||
| // so for example if user just click the input and clicks out without changing anything | ||
| if (amountOfProductBeforeBlur === amountOfProduct) return; | ||
| await mutateAsync(); | ||
| await queryClient.invalidateQueries({ | ||
| queryKey: QueryAndMutationKeys.CartProducts, | ||
| }); | ||
| try { | ||
| // this will prevent request sent to backend if amount of products were same | ||
| // so for example if user just click the input and clicks out without changing anything | ||
| if (amountOfProductBeforeBlur === amountOfProduct) return; | ||
| await mutateAsync(); | ||
| await queryClient.invalidateQueries({ | ||
| queryKey: QueryAndMutationKeys.CartProducts, | ||
| }); | ||
| } catch (e) { | ||
| handleError(e); | ||
| } |
anttiasmala
commented
Jul 29, 2025
Comment on lines
-32
to
+37
| export type GetCart = { amount: number; createdAt: Date; updatedAt: Date } & { | ||
| export type GetCart = { | ||
| amount: number; | ||
| createdAt: Date; | ||
| updatedAt: Date; | ||
| whenRequestSent?: Date; | ||
| } & { |
Owner
Author
There was a problem hiding this comment.
whenRequestSent's idea is to tell when the request was sent. Just to make GET request of products change every time so useEffect will "grab" them
anttiasmala
commented
Jul 29, 2025
Comment on lines
-224
to
+225
| console.error(e); | ||
| handleError(e); |
Owner
Author
There was a problem hiding this comment.
handleError is better here
anttiasmala
commented
Jul 29, 2025
Comment on lines
-276
to
+278
| await queryClient.invalidateQueries({ | ||
| queryKey: QueryAndMutationKeys.CartProducts, | ||
| }); | ||
| await refetchCartProducts(queryClient); |
Owner
Author
There was a problem hiding this comment.
Add this new function to replace the old queryClient.invalidateQueries etc. Might make the function generic later on
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Products can be added to cart until max stock amount is reached