Skip to content

[vibe coded] updated gtk crate and friends - #319

Merged
antoyo merged 19 commits into
antoyo:masterfrom
kazam0180:master
Jul 23, 2026
Merged

[vibe coded] updated gtk crate and friends#319
antoyo merged 19 commits into
antoyo:masterfrom
kazam0180:master

Conversation

@kazam0180

@kazam0180 kazam0180 commented May 3, 2026

Copy link
Copy Markdown
Contributor

No description provided.

antoyo
antoyo reviewed May 3, 2026
View reviewed changes
Comment thread Cargo.toml Outdated
@kazam0180

kazam0180 commented May 9, 2026

Copy link
Copy Markdown
Contributor Author

@antoyo check now

@antoyo

antoyo commented May 31, 2026

Copy link
Copy Markdown
Owner

Sorry for the delay. I forgot about this PR.
The CI fails: could you please fix it?
Thanks.

@kazam0180

kazam0180 commented May 31, 2026

Copy link
Copy Markdown
Contributor Author

Sorry for the delay. I forgot about this PR. The CI fails: could you please fix it? Thanks.

I updated the libwebkit package name but I never used clippy. I will look into it later some time.

@kazam0180

kazam0180 commented Jul 19, 2026

Copy link
Copy Markdown
Contributor Author

hey @antoyo is it okay if i update the rust edition to 2024?

@antoyo

antoyo commented Jul 19, 2026

Copy link
Copy Markdown
Owner

Yes, it is OK.

kazam0180 added 6 commits July 19, 2026 16:42
@kazam0180
Update to edition 2024, gtk-rs 0.18, fix all clippy errors
00cf4e9 
- Bump all Cargo.toml to edition 2024
- Bump gtk-rs deps from 0.16 to 0.18 across all crates and examples
- Fix Inhibit -> glib::Propagation in 66+ source files and .relm DSL
- Fix Object::new -> Object::builder in relm-derive codegen
- Fix gen reserved keyword -> r#gen in relm-derive
- Fix pat -> pat_param in relm-test macro_rules
- Add unsafe blocks in src/core/source.rs for edition 2024
- Fix clippy: doc_lazy_continuation, enum_variant_names, large_enum_variant, collapsible_match, collapsible_if
@kazam0180
CI: uncomment webkit-test, update minimum Rust to 1.85.0 (edition 2024)
6855583
@kazam0180
Bump MSRV to 1.86.0 for if-let chains stability
8eabacf
@kazam0180
Bump MSRV to 1.88.0 for if-let chains stability
6c1edd9
@kazam0180
Add at-spi2-core to workflow dependencies
e913d93
@kazam0180
Fix nightly: remove trailing semicolon from relm_observer_new! macro
20f1fa4
@kazam0180

kazam0180 commented Jul 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@antoyo was there a hang in input related tests before my updates? i cancelled the workflow in my repo but actions in your repo have been running for 2 hours

@kazam0180

kazam0180 commented Jul 19, 2026

Copy link
Copy Markdown
Contributor Author

man you're gonna run out of actions usage...

@antoyo

antoyo commented Jul 19, 2026

Copy link
Copy Markdown
Owner

I believe open source projects have unlimited minutes of GitHub Actions, so this should be fine.

@antoyo

antoyo commented Jul 19, 2026

Copy link
Copy Markdown
Owner

@antoyo was there a hang in input related tests before my updates?

Maybe there was a bug with enigo. Let me check.

antoyo
antoyo reviewed Jul 22, 2026
View reviewed changes

@antoyo antoyo left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the CI.
Here are a few things to fix.

Comment thread relm-derive/src/gen/generator.rs Outdated
Comment thread relm-derive/src/generator/generator.rs
Comment thread relm-derive/src/gen/parser.rs Outdated
Comment thread relm-derive/src/generator/parser.rs
Comment thread relm-derive/src/gen/transformer.rs Outdated
Comment thread relm-examples/examples/drawing.rs Outdated
Comment thread .github/workflows/CI.yml
Comment thread relm-derive/src/gen/walker.rs Outdated
kazam0180 and others added 2 commits July 22, 2026 20:48
@kazam0180
change checkout action version to 6
10a48fd
@kazam0180 @antoyo
Update relm-derive/src/gen/walker.rs
abf33e3 
Co-authored-by: antoyo <antoyo@users.noreply.github.com>
@kazam0180

kazam0180 commented Jul 22, 2026

Copy link
Copy Markdown
Contributor Author

i will apply these suggestion when i wake up.

antoyo
antoyo reviewed Jul 22, 2026
View reviewed changes
Comment thread relm-derive/src/gen/walker.rs Outdated
antoyo
antoyo reviewed Jul 23, 2026
View reviewed changes
Comment thread relm-derive/src/generator/generator.rs
antoyo
antoyo reviewed Jul 23, 2026
View reviewed changes
Comment thread relm-derive/src/generator/transformer.rs Outdated
antoyo
antoyo reviewed Jul 23, 2026
View reviewed changes
Comment thread .gitignore Outdated
antoyo
antoyo reviewed Jul 23, 2026
View reviewed changes

@antoyo antoyo left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing to fix.
After that, I believe we can merge this!
Thanks for your work.

Comment thread relm-examples/examples/drawing.rs Outdated
@kazam0180

kazam0180 commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

ah, my bad

@kazam0180

kazam0180 commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

that should be all

@antoyo
antoyo merged commit d5800dd into antoyo:master Jul 23, 2026
4 checks passed
@antoyo

antoyo commented Jul 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Owner

Thanks for your contribution.

I'll attempt to make a release now.
Let's hope the release script still works after all those years.

Edit: The release is done.

@antoyo antoyo mentioned this pull request Jul 23, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antoyo antoyo antoyo left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kazam0180 @antoyo