Update params.seed when -S is not given#30
Open
gpakosz wants to merge 1 commit into
Open
Conversation
Kartones
added a commit
to Kartones/iris.c
that referenced
this pull request
Apr 2, 2026
clort81
reviewed
Apr 14, 2026
There was a problem hiding this comment.
The params.seed is the seed given to the program
case 'S': params.seed = atoll(optarg); break;
the actual_seed is the seed actually used by the program.
Setting params.seed to the randomly generated seed has no effect. And makes no logical sense, since no seed was passed as a parameter.
I suggest closing this.
[Edit:] Sorry I hadn't looked into iris_cli. There i see
static int generate_image(....
params.seed = actual_seed;
Not sure about that cli stuff. Sorry for my comment, leaving it up though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the following use case
Generating different images.