Improve Gemma4 long-context correctness and Metal decode performance - #473
Open
timkaye11 wants to merge 3 commits into
Open
Improve Gemma4 long-context correctness and Metal decode performance#473timkaye11 wants to merge 3 commits into
timkaye11 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[codex]
Summary
This PR improves Gemma4 E2B/E4B long-context inference
ignore_eoshandling.Benchmarks
Local, unattested Apple Metal measurements use ReleaseFast builds and fresh processes. The comparator is the branch's exact main fork point; decode excludes prefill.
An additional E2B 2,065+300 long-output check used one warmup and five measured fresh processes:
Validation
-Dmetal=false, and ReleaseFast Metal builds passed.