fix(x-sdk): support Node timeout handles - #169
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 本次变更属于 ...
🔗 相关 Issue
无。
💡 背景与方案
x-sdk在 Node 类型环境中,setTimeout返回Timeout,但请求与流式请求的定时器句柄声明为number,导致类型检查失败。将两个句柄类型改为
ReturnType<typeof setTimeout>,与已有的重试定时器保持一致,并兼容浏览器与 Node 运行时。📝 变更日志
✅ 验证
vp run --filter @antdv-next/x-sdk type-checkvp lint packages/x-sdkvp test packages/x-sdk/src/x-request/__tests__/index.test.ts --environment node