Add claude review command - #794
Draft
Akasurde wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Abhijeet Kasurde <Akasurde@redhat.com>
Shrews
requested changes
May 12, 2026
| @@ -0,0 +1,3 @@ | |||
| - @AGENTS.md | |||
Contributor
There was a problem hiding this comment.
We will need to add an AGENTS.md file specific to this project. I have a CLAUDE.md we could probably modify a bit to include here (or seperately).
| @@ -0,0 +1,3 @@ | |||
| - @AGENTS.md | |||
| - @~/.claude/ansible.md | |||
Contributor
There was a problem hiding this comment.
We shouldn't re-use the one from ansible core. Probably name it ansible-builder.md.
| - **Licensing**: Verify Apache License 2.0 compatibility for any new dependencies | ||
| - **Test scope**: Tests must exercise actual changed code, not just add random coverage | ||
| - **Changelog**: No changelog fragments needed - managed via GitHub releases | ||
| - **Testing**: Uses tox/pytest (not ansible-test). Check CI passes for linters, unit, and integration tests |
Contributor
There was a problem hiding this comment.
This project doesn't know anything about ansible-test so I don't think we need to mention that here.
|
|
||
| - **Licensing**: Verify Apache License 2.0 compatibility for any new dependencies | ||
| - **Test scope**: Tests must exercise actual changed code, not just add random coverage | ||
| - **Changelog**: No changelog fragments needed - managed via GitHub releases |
Contributor
There was a problem hiding this comment.
This project doesn't know anything about changlog fragments. We don't need to bleed ansible-core things over into this project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Signed-off-by: Abhijeet Kasurde Akasurde@redhat.com
ISSUE TYPE
COMPONENT NAME
.claude/commands/review.md
CLAUDE.md