Enable edge to edge for FilteredDeckOptionsFragment - #21597
Open
lukstbit wants to merge 1 commit into
Open
Conversation
Edge to edge was enabled for ConfigAwareSingleFragmentActivity which is used as a container for FilteredDeckOptionsFragment and ScheduleRemindersFragment.
criticalAY
added
Needs Second Approval
david-allison
approved these changes
Aug 24, 2026
david-allison
left a comment
david-allison
left a comment
Member
There was a problem hiding this comment.
LGTM, merge at will
Optional suggestion to make the navigation bar match the background color
david-allison
added
Needs Author Reply
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
Enable edge to edge for FilteredDeckOptionsFragment. I had this implemented manually but waited after seeing criticalAY's latest PR.
The changed activity, ConfigAwareSingleFragmentActivity is used both by FilteredDeckOptionsFragment and by ScheduleRemindersFragment(in DeckPicker). With these changes ScheduleRemindersFragment doesn't respect edge to edge but I didn't do anything about this yet to wait for #21519.
Some images:
API 28:
API 36:
Fixes
How Has This Been Tested?
Manually on two devices: API 28(big notch + system bars) and API 36(punch cutout + system bars).
Checklist