feat[ManageSpaceActivity]: Edge to edge support - #21576
Merged
Merged
Conversation
criticalAY
force-pushed
the
edge-to-edge-manage-space
branch
from
August 22, 2026 14:38
e73ffee to
22884b2
Compare
Contributor
|
Snapshot diff report vs
All 3 changed screenshotsManageSpaceScreenshotTest
|
david-allison
approved these changes
Aug 22, 2026
Comment on lines
+52
to
+53
| /** Whether this host is ported to edge to edge (17334) */ | ||
| open val supportsEdgeToEdge: Boolean get() = false |
Member
There was a problem hiding this comment.
Ouch - is it feasible to add GitHub issues for any fragments which are necessary (and make this abstract + implement in each screen which needs porting)
[if this is asking too much; leave it as an issue to implement]
Contributor
Author
There was a problem hiding this comment.
I would go with an issue here
david-allison
added
Needs Second Approval
The `AppBarLayout` keeps `fitsSystemWindows`, so its `CollapsingToolbarLayout` applies the top inset itself. Removing it glitches the status bar as the toolbar collapses, which `ScheduleRemindersFragment` already records for the same widget stack. Only the root's flag is turned off, so this screen's listener sees the insets at all. Assisted-by: Claude Opus 5
Assisted-by: Claude Opus 5
criticalAY
force-pushed
the
edge-to-edge-manage-space
branch
from
August 24, 2026 05:27
22884b2 to
b223a63
Compare
lukstbit
added
Pending Merge
github-actions
Bot
removed
Review High Priority
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Assisted-by: Claude Opus 5
Purpose / Description
Port ManageSpaceActivity to support edge to edge
Fixes
ManageSpaceActivity#21516Approach
See commits
How Has This Been Tested?
API 36 and API 28:
Learning (optional, can help others)
NA
Checklist
Please, go through these checks before submitting the PR.