refactor: handle onRenderProcessGone in image preview - #21565
Open
criticalAY wants to merge 1 commit into
Open
Conversation
criticalAY
marked this pull request as draft
August 19, 2026 17:22
The preview never set a WebViewClient, so the default onRenderProcessGone ran and returned false, killing the app process instead of the preview so use SafeWebViewLayout
criticalAY
force-pushed
the
17486-multimedia-render-process-gone
branch
from
August 19, 2026 17:54
0e19f56 to
c5ade06
Compare
criticalAY
marked this pull request as ready for review
August 19, 2026 17:54
david-allison
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
InvocationTargetException: Cannot call WebViewCachedFlags.init more than once. #21529 shows users a Chromium assert,Cannot call WebViewCachedFlags.init more than once, which says nothing about why their app won't start. Android doesn't cache a failed WebView load, so our second WebView call re-runs Chromium's provider constructor and dies on re-entry, while the first failure, the real one, was already thrown away. This keeps the first failure so the crash report actually tells us what broke.Fixes
InvocationTargetException: Cannot call WebViewCachedFlags.init more than once. #21529Approach
See commit
How Has This Been Tested?
Unit testing
Learning (optional, can help others)
NA
Checklist
Please, go through these checks before submitting the PR.