feat: analytics typed events - #21554
Open
criticalAY wants to merge 7 commits into
Open
Conversation
Assisted-by: Claude Fable 5
Category and action are now fixed at each event's declaration, so runtime data can only reach the label or value.
Assisted-by: Claude Opus 5
No widget ever used it, and it handed out the raw analytics instance. Assisted-by: Claude Opus 5
The widget providers were the last outside readers. Assisted-by: Claude Opus 5(this was pointed out by Claude)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Assisted-by: Claude Opus 5 (few commits)
Purpose / Description
We were passing raw strings for category and action, so nothing stopped a variable from landing in a field that is compared between AnkiDroid versions, and nothing enforced that a category and action actually belong together. So here enforcing the runtime data
Fixes
Approach
See commits
How Has This Been Tested?
Locally build and unit testing
Learning (optional, can help others)
NA
Checklist
Please, go through these checks before submitting the PR.