refactor: more extractions for :widgets submodule - #21532
Draft
david-allison wants to merge 8 commits into
Draft
Conversation
david-allison
force-pushed
the
widgets-2
branch
from
August 16, 2026 11:23
967af57 to
fc89bd1
Compare
* onCreate() returns early if `setupAnkiDroidApp()` fails * ContentProvider performs an early init We don't want these to crash. Trade-off: a missed `setReporter()` call now degrades to warnings instead of failing fast. The rationale was also to allow tests to run without needed a no-op crash report handler. Assisted-by: Claude Fable 5
david-allison
added
the
Blocked by dependency
097c7cd` moved `CollectionManager` down, so these methods can now be moved to `:anki-common`. More work for the for `:widgets` multimodule migration Part of 20737 Assisted-by: Claude Fable 5
Part of 20737 Assisted-by: Claude Fable 5
Part of 20737 Assisted-by: Claude Fable 5
For the `:widget` feature module extraction Part of 20737 Assisted-by: Claude Opus 4.8 Assisted-by: Claude Fable 5 (cherry picked from commit 28885ffe7d677a28397b5ffddc32561d29ce4cca)
TestChangeSubscriber moves to testFixtures, and ChangeManagerTest uses its ChangeCounter directly Part of 20737 Assisted-by: Claude Fable 5
Part of 20737 Assisted-by: Claude Fable 5
For the widget feature module extraction Part of 20737 Assisted-by: Claude Opus 4.8 (cherry picked from commit 28885ffe7d677a28397b5ffddc32561d29ce4cca)
david-allison
force-pushed
the
widgets-2
branch
from
August 16, 2026 12:26
fc89bd1 to
803fa25
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DRAFT:
NoOpCrashReporter- fix(crash-reporting): don't crash if triggered before init #21533Note
Assisted-by: Claude Fable 5
Purpose / Description
fromDeckIdandfromCurrentDecklaunchCatchingChangeManagerFixes
Approach
Standard extactions
How Has This Been Tested?
Checklist