Harden installer, add CHANGELOG for v0.1.0 - #4
Merged
Merged
Conversation
The installer had two real defects. It minted the API key with `openssl rand`, which Termux does not ship, so a fresh setup failed at the key step; it now uses python's secrets module, which is always present. And it installed only the CPU build, so a fresh phone silently ran everything on the CPU at a quarter of the speed; it now pulls the Vulkan backend and Mesa's turnip driver that put prompt processing on the Adreno GPU. It also installs the RAG pipeline (ragcore plus the three entry points) and the python runtime, runs a preflight (Termux present, aarch64, enough free space) that fails early with a clear message, prints a GPU-detected line when Vulkan comes up, and is idempotent — an existing key is never overwritten. fetch-model.sh now pins and verifies the model's SHA256: it skips the download when the file is already present and correct, and fails loudly on a mismatch instead of leaving a corrupt model in place. Verified against the model on the device — the pinned hash matches and a re-run exits without re-downloading.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Installer now pulls the Vulkan GPU packages and the RAG pipeline, mints the key with python (Termux has no openssl), runs a preflight, and is idempotent. fetch-model.sh pins and verifies the model SHA256 (verified against the device). Adds CHANGELOG.md for the v0.1.0 release. Shellcheck clean, 60 tests passing.