Smooth streaming scroll and drop header em dash - #3
Merged
Conversation
Scrolling up to re-read while the answer streamed was janky: every token called scrollIntoView and yanked the viewport back to the bottom, fighting the manual scroll. Autoscroll is now sticky — it follows the stream only while the reader is already at the bottom, and stops the moment they scroll up. One scroll listener for the page instead of one added per question. Header now reads "note chunks. Retrieval first" instead of joining the clauses with an em dash.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scrolling up to re-read while an answer streamed was janky: every token called
scrollIntoViewand yanked the viewport back down, fighting the manual scroll. Autoscroll is now sticky — it follows the stream only while the reader is at the bottom, and stops the moment they scroll up. One page-level scroll listener instead of one per question. Header reworded to drop the em dash. Suite 60 passing; verified live on device.