fix: clean up debug logs, typo, and dead conditional in Sponsors Section#384
Open
AVA-NTHIKA14 wants to merge 1 commit into
Open
fix: clean up debug logs, typo, and dead conditional in Sponsors Section#384AVA-NTHIKA14 wants to merge 1 commit into
AVA-NTHIKA14 wants to merge 1 commit into
Conversation
…n Sponsors Section
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Small cleanup of leftover debug code and a styling typo found while reviewing the Projects/Sponsors and AboutUs components:
console.log(index)left inSponsors/Section/index.jsconsole.log(error)left inAboutUs/Oscommunity.js's fetch error handler{setShowMore && <Text>...}—setShowMoreis a state setter function, so it's always truthy and the condition had no effectforntSize→fontSizeinmoreTextstyle, which meant the "View more / Show less" link never received its intended 16px font sizeType of change
How this was tested
Ran the app locally with
npm startand confirmed the Projects page sponsor sections (expand/collapse "View more") and the AboutUs page contributor icons render correctly. Existing test suite passes withnpm test.