Harden the release pipeline and close review findings - #7
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Fixes two defects found in review of 0c11c95: - gh release upload uploads its arguments concurrently, so the prior single-call upload of zip+dmg+appcast guaranteed no ordering. On the clobber path, where the release is already live, this could publish a new appcast pointing at a zip that had not finished uploading yet, or lose all three assets outright on a failed --clobber upload. Split into two sequential gh release upload calls: zip+dmg, then appcast. - gh release edit --draft=false only ran on the create path. A run that died between creating the draft and publishing it left the release stranded as a draft forever: gh release view resolves drafts, so the next re-run took the clobber path, uploaded fresh assets, and never published it. The draft flip now runs unconditionally on both paths, after the uploads, and re-asserts --prerelease when PRERELEASE=true rather than assuming gh release edit leaves the flag alone -- which also restores the flag on a hand-promoted release's own re-run. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
The gentle-reminder path is verified by code inspection against Sparkle's headers rather than by a live update. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
latest; tests gate signing; drafts publish atomically with appcast last; signing identity and zip notarization are asserted;create-dmginstalls before the key is imported; CI permissions, pinned blocking linters, andqueue: maxso a third tag cannot drop a pending release.Test plan
swift test(52 tests) andshellcheck -x -s sh scripts/*.sh/actionlinton the PR’s lint jobcurlinstall has never executed onubuntu-latestlocally)APPLE_TEAM_IDmust match the imported certdepends_on arch: :arm64inCasks/winmice.rb(documented indocs/releasing.md)Made with Cursor