fix(gui): keep artifact responses scoped to their session - #500
Open
wgu9 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
RightRailapplied everygetArtifacts()andreadArtifact()completion directly to shared component state. If a user switched sessions, refreshed twice, or selected another artifact while an earlier request was still in flight, that older success could replace the current list or preview. An older failure could also clear a newer successful list.The fix gives list and content requests separate monotonically increasing request IDs. Only the newest owner may update state, and session switches invalidate and clear the previous session's artifacts before loading the new list.
Before / after
The screenshots use the same delayed-response Playwright reproduction: session A's request is held, the UI switches to session B and renders
current.md, then session A's request is released.Validation
npm test— 115 passednpm run build— passedorigin/mainand this branch