fix(server): surface crashed WS turns as error events - #495
Open
AliAltivate wants to merge 1 commit into
Open
Conversation
run_turn was scheduled with asyncio.create_task and a try/finally with no except: an unexpected exception escaping engine.run() or retry() died as an unretrieved task exception and the GUI saw only a bare turn_done — a silently dead turn with zero feedback. Broadcast an error event first, mirroring the background-turn path in deliver_to_session. Fixes andrewyng#367.
Author
|
Hi — just a friendly ping on this one. It's a small fix with a test included; would appreciate a review whenever you get a chance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
run_turn was scheduled with asyncio.create_task and a try/finally with no except: an unexpected exception escaping engine.run() or retry() died as an unretrieved task exception and the GUI saw only a bare turn_done — a silently dead turn with zero feedback. It now broadcasts an error event first, mirroring the background-turn path in deliver_to_session.
Fixes #367.