fix: use an LRU cache for cached patterns#60
Merged
Conversation
blemoallic
force-pushed
the
fix/use_lru_cache
branch
from
June 2, 2026 08:34
335b697 to
c8dad26
Compare
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously cache used was a LIFO cache: when cache size were >
_MAXCACHE, we used_cache.popitem()that removes the 1st element of the cache and then_cache[cachekey] = pto add element to cache, that add the item to the top of the cache.This PR introduces
OrderedDictfor cache management and changes LIFO behaviour to LRU.Closes #59