Skip to content

Changing from php to go - #1

Open
andreaskasper wants to merge 15 commits into
mainfrom
golang-dev
Open

Changing from php to go#1
andreaskasper wants to merge 15 commits into
mainfrom
golang-dev

Conversation

@andreaskasper

Copy link
Copy Markdown
Owner

No description provided.

Copy link
Copy Markdown
Owner Author

Triage note from the weekly maintenance pass (2026-08-01).

This PR ("Changing from php to go", branch golang-dev, opened 2021-03-20) looks superseded. The Go rewrite landed on main a long time ago — main now carries the full Go implementation under src/go/ (handler.go, routes.go, traps.go, honeytokens, AbuseIPDB reporting, Prometheus metrics), and Dockerfile builds exclusively from src/go/. Nothing in this branch is reachable from the current build.

Recommendation: close without merging and delete the golang-dev branch. Merging a 5-year-old branch into today's main would almost certainly reintroduce the duplicate-declaration class of breakage that was cleaned up in #2 (b4bae12, 3e4e671).

One related loose end: src/php/ is still in the tree but is not referenced by the Dockerfile or any workflow. If it's kept deliberately as historical reference, a one-line note in README.md would save the next reader a detour; otherwise it could go in the same cleanup.

Not merging or closing anything myself — leaving the call to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant