feat(destinations): openapi for Outpost queue types (SQS/PubSub/RabbitMQ reshape + Azure Service Bus, Kafka) + drop SNS (ENG-4130) - #399
Merged
Conversation
…tMQ reshape + Azure Service Bus, Kafka) + drop SNS (ENG-4130) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…upported (ENG-4130) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reshapes the message-queue destination OpenAPI schemas to match the final builder-facing contract now that message-queue destinations are reimplemented on Outpost (replacing Svix). Destination metadata/secrets are modeled as a single shared flat schema with per-type semantics documented in field descriptions (the existing repo convention); these edits add/remove named fields, update the
typeenum, and adjust theupdateMaskallowed-paths list.Changes
sqs— metadata:queueUrl(required),endpointUrl(optional); noregion. secrets: now usesawsKeyId(required),awsSecretKey(required),awsSessionToken(optional) instead ofaccessKeyId/secretAccessKey.pubsub— metadata:projectId(required),topicId(required). secrets:credentials(required).rabbitmq— metadata:serverUrl(required),exchange(required),tls(optional bool); removedroutingKey. secrets:username(required),password(required); removeduri.azureservicebus(new) — metadata:name(required). secrets:connectionString(required).kafka(new) — metadata:brokers(required),topic(required),saslMechanism(required; enumplain/scram-sha-256/scram-sha-512),tls(optional bool),partitionKeyTemplate(optional). secrets:username(required),password(required).sns— removed entirely (dropped from thetypeenum and itstopicArnmetadata removed).eventbridge,azureblob,gcs, warehouse types, webhook, slack, kinesis, s3 are untouched.Final
typeenum[webhook, kinesis, s3, slack, clickhouse, snowflake, bigquery, redshift, sqs, eventbridge, pubsub, rabbitmq, azureservicebus, kafka]Files
api/api.yaml— createDestination request body (enum + metadata + secrets), updateDestinationupdateMasklist + nested metadata/secrets,DestinationandDestinationWithSecretsresponse schemasapi/generated/api.json,api/generated/api.bundled.json— regenerated viamake gencatalog/generated/catalog.jsonchurn from generation was reverted to keep the diff focused on destinations.🤖 Generated with Claude Code