feat(destinations): add batchSize/maxWaitSecs to warehouse destination metadata (ENG-4130) - #395
Merged
Merged
Conversation
…n metadata (ENG-4130) Optional integer fields on warehouse destination metadata (clickhouse, snowflake, bigquery, redshift) to tune Svix sink batching; default to 1000 rows / 30s when unset. Added to create/update bodies, updateMask, and both response schemas. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #394. Adds optional
batchSizeandmaxWaitSecsinteger fields to warehouse destination metadata (clickhouse,snowflake,bigquery,redshift), matching server#7057 (SinkBatching).These tune Svix sink batching — warehouse sinks flush a batch when it reaches
batchSizerows or aftermaxWaitSecsseconds. Unset → server defaults (1000 / 30s). Testing showed that without amaxWaitSecs, a low-volume warehouse destination never flushed; exposing these lets builders tune the latency/efficiency trade-off.Added to the create body, update body,
updateMask, and both response schemas. Regeneratedapi/generated/*.json.