Fix arm64 for simulator - #11
Open
LudySu wants to merge 2 commits into
Open
Conversation
…e as v1.5.0 did for Android
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently iOS apps using this package would not be able to run on iOS 26+ simulator, because the libmp3lame.a archive was built for device while lacks support for arm64 simulator. This PR properly fixes issue #5
In this PR, the package is compiling libmp3lame from source code like what we did for Android in 1.5.0. Now they are referencing the same libmp3lame source code at the project's root folder
lame_3.99.5_libmp3lame.Note that the iOS compiler/cocoapod can not reference relative path pointing to parent like
../.., nor can it reference a symlink folder. So I have to create symlinks for every single file inlame_3.99.5_libmp3lamefolderFeel free to edit this PR
Verified: