fix: update film development recipes with corrected times and standardized naming#118
Merged
Conversation
Contributor
📝 WalkthroughSummary by CodeRabbit
Walkthrough
Changesレシピ表記の正規化
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@data/recipes.json`:
- Around line 5-70: The recipe records are still storing time values in an
unsupported decimal-string format, which does not match the standardization
requirement. Update the recipe data entries referenced in the JSON and ensure
the `time` values use one canonical format consistently, either `m min` or
`MM:ss`, and align `recipes.go` so it emits the same chosen representation
instead of passing through the old string form. Keep the format consistent
across all recipe objects so the database and API share a single canonical
`time` format.
- Line 224: The "time" value for this recipe looks like a mistaken range
normalization because 4.5 falls outside the original "6-7" span and is
inconsistent with the other conversions in this PR. Update the time entry in
recipes.json to a value that stays within the source range, matching the
normalization pattern used elsewhere (for example the other time conversions
like 6.5, 8.5, and 14).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 16b88eda-19d1-47d7-9ac2-ccdeaf6dc55a
📒 Files selected for processing (1)
data/recipes.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed #117
書式の統一,データの修正を含む