Skip to content

fix: update film development recipes with corrected times and standardized naming#118

Merged
amemya merged 1 commit into
mainfrom
feat/format-dev-db
Jun 26, 2026
Merged

fix: update film development recipes with corrected times and standardized naming#118
amemya merged 1 commit into
mainfrom
feat/format-dev-db

Conversation

@amemya

@amemya amemya commented Jun 26, 2026

Copy link
Copy Markdown
Owner

fixed #117

書式の統一,データの修正を含む

@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Summary by CodeRabbit

  • バグ修正
    • 一部レシピの現像条件表記を統一し、dilution の表記ゆれを修正しました。
    • time の表記を範囲や分:秒形式から、より明確な単一の小数値に更新しました。
    • 複数の主要レシピで処理時間の表示が見やすく、比較しやすくなりました。

Walkthrough

data/recipes.json の複数レシピで、dilution 表記を小文字に統一し、time の範囲表記や m:ss 表記を単一の小数値へ置換した。

Changes

レシピ表記の正規化

Layer / File(s) Summary
冒頭の 400 系レシピ更新
data/recipes.json
Kodak Tri-X 400、Kodak T-Max 400、Ilford HP5 Plus 400、Kentmere 400、Fomapan 400 の dilution と time が更新された。
Fomapan 100 の更新
data/recipes.json
Fomapan 100 の D-76、ID-11、Microphen、XTOL の time が範囲表記から単一値へ更新された。
後半のレシピ更新
data/recipes.json
Ilford Delta 100 と Fujifilm Neopan 100 Acros II の time が更新された。

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning issue #117 は m min か MM:ss への統一を求めますが、このPRは小数値へ置換しており要件に一致しません. 時間表記を m min か MM:ss に統一し、範囲値の扱いは issue の方針に沿って別途整理してください.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed タイトルは film development recipes の時間修正と命名統一という主変更を簡潔に表しています.
Description check ✅ Passed 説明は #117 の書式統一とデータ修正に関連しており、変更内容と整合しています.
Out of Scope Changes check ✅ Passed 変更はレシピの時間表記と dilution 名の正規化に限られ、目的外の大きな追加変更は見当たりません.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/format-dev-db

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@data/recipes.json`:
- Around line 5-70: The recipe records are still storing time values in an
unsupported decimal-string format, which does not match the standardization
requirement. Update the recipe data entries referenced in the JSON and ensure
the `time` values use one canonical format consistently, either `m min` or
`MM:ss`, and align `recipes.go` so it emits the same chosen representation
instead of passing through the old string form. Keep the format consistent
across all recipe objects so the database and API share a single canonical
`time` format.
- Line 224: The "time" value for this recipe looks like a mistaken range
normalization because 4.5 falls outside the original "6-7" span and is
inconsistent with the other conversions in this PR. Update the time entry in
recipes.json to a value that stays within the source range, matching the
normalization pattern used elsewhere (for example the other time conversions
like 6.5, 8.5, and 14).
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 16b88eda-19d1-47d7-9ac2-ccdeaf6dc55a

📥 Commits

Reviewing files that changed from the base of the PR and between 03c020b and 90f77e7.

📒 Files selected for processing (1)
  • data/recipes.json

Comment thread data/recipes.json
Comment thread data/recipes.json
@amemya amemya merged commit 80545f8 into main Jun 26, 2026
4 checks passed
@amemya amemya deleted the feat/format-dev-db branch June 26, 2026 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DBの書式を揃える

1 participant