feat: implement progress bar for export all #115
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
Walkthrough
Changesエクスポート進捗表示
推定コードレビュー工数🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@frontend/src/hooks/useExport.ts`:
- Around line 124-126: The onProgress callback is being called directly at
multiple locations throughout the useExport hook without exception handling, and
the cleanup operations (setIsSelecting(false) and isSelectingRef.current =
false) are not guaranteed to execute if onProgress throws an exception. Wrap all
direct calls to onProgress in try/catch blocks to isolate any callback
exceptions, and ensure that the cleanup logic for setIsSelecting and
isSelectingRef.current is moved into a finally block so it executes regardless
of whether the onProgress callback succeeds or fails. This applies to the
onProgress calls at the initial progress notification, the intermediate progress
updates, and the final completion notification to prevent operation locks from
remaining active when the callback fails.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 2b5905b5-a8fc-4f69-ae9d-26382a305255
📒 Files selected for processing (2)
frontend/src/App.tsxfrontend/src/hooks/useExport.ts
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@frontend/src/hooks/useExport.ts`:
- Line 204: 進捗更新が失敗時のcontinue経路で抜け落ちています。useExport.ts の import ループ内で
safeOnProgress を呼んでいる箇所を見直し、Line 154 / Line 180 の失敗分岐でも必ず実行されるように、同じループの
try/finally の finally 側へ移動してください。これにより importedImages.length
を基準にした進捗表示が各画像処理後に必ず更新されます。
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: bba58bef-8dba-4359-a31e-fe3a06907ad4
📒 Files selected for processing (1)
frontend/src/hooks/useExport.ts
|
@coderabbitai review |
✅ Action performedReview finished.
|
resolved #110
書き出しの進捗を表示するプログレスバーを実装