feat: support beta channel updates#114
Merged
Merged
Conversation
Contributor
📝 WalkthroughSummary by CodeRabbit
Walkthrough
Changesベータ更新受信トグル機能
Sequence Diagram(s)sequenceDiagram
participant User
participant SettingsWindow
participant Settings as settings.go
participant dynamicGithubProvider
participant stableProvider
participant betaProvider
User->>SettingsWindow: "Receive Beta Updates" チェックボックスを切り替え
SettingsWindow->>Settings: handleSave → enableBetaUpdates を書き込み
Note over Settings: EnableBetaUpdates が永続化される
User->>dynamicGithubProvider: 更新チェック
dynamicGithubProvider->>Settings: settingsMu.RLock → EnableBetaUpdates を読み取り
alt EnableBetaUpdates == true
dynamicGithubProvider->>betaProvider: Check() (Prerelease: true)
else EnableBetaUpdates == false
dynamicGithubProvider->>stableProvider: Check() (Prerelease: false)
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@updater.go`:
- Around line 31-50: The dynamicGithubProvider methods Check and Download both
independently read currentSettings.EnableBetaUpdates to determine which provider
to use, creating a race condition where settings changes between these calls
cause provider inconsistency. Modify the Check method to record which provider
(betaProvider or Provider) was selected and store this information as metadata
in the returned Release object. Then update the Download method to retrieve this
stored provider information from the Release object and use the same provider
that was selected during Check, eliminating the need for a second
currentSettings read in Download.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: d9f8663f-f39c-48c0-9634-951d2012a37e
📒 Files selected for processing (3)
frontend/src/SettingsWindow.tsxsettings.goupdater.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Beta版を含むかどうか選択可能に
(fixes #60)