ci: add pnpm build gate on develop/main PRs#33
Merged
Conversation
Adds a Build gate workflow running `pnpm build` on push/PR to develop and main. `next build` performs the TypeScript type-check, so this catches incomplete provider integrations (PROVIDER_META / by_provider not wired) that break the tsc build — the recurring incident blocking main merges. Investigation: `pnpm build` requires NO build-time env vars. Verified in a hermetic run (env -i, no .env files, CI=true): EXIT=0, TypeScript step passes. App env access is lazy (inside route handlers/functions), so no secrets need to be configured in GitHub Actions for this gate. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
.github/workflows/build.yml— a Build gate runningpnpm buildon push/PR todevelopandmain.Why
next buildruns the TypeScript type-check, so this gate catches incomplete provider integrations (PROVIDER_META/by_providernot wired) that break thetscbuild — the recurring incident that has repeatedly blocked main merges.Investigation result (the original Otto task)
pnpm buildrequires NO build-time env vars. Verified in a hermetic run (env -i, no.envfiles on disk,CI=true):All app env access is lazy (inside route handlers / functions, e.g.
src/lib/crypto.ts,src/lib/payments.ts,src/lib/paddle/server.ts), so nothing throws at module-load / build time. No GitHub Actions secrets need to be configured for this gate to pass.🤖 Generated with Claude Code