common : fix --no-mmproj still downloading mmproj with -hf#19
Draft
am17an wants to merge 1 commit into
Draft
Conversation
When using -hf with --no-mmproj, the mmproj file was still being downloaded because common_params_handle_model always passed true for download_mmproj. The no_mmproj check only cleared params.mmproj after the download had already occurred. Add a search_mmproj parameter to common_params_handle_model and pass !params.no_mmproj from the caller to skip the download entirely. Assisted-by: llama.cpp:local pi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
When using
-hfwith--no-mmproj, the mmproj file was still being downloaded becausecommon_params_handle_modelalways passedtruefordownload_mmproj. Theno_mmprojcheck only clearedparams.mmprojafter the download had already occurred.Add a
search_mmprojparameter tocommon_params_handle_modeland pass!params.no_mmprojfrom the caller to skip the download entirely.Requirements